pass input metadata to resource#1069
Merged
SteveL-MSFT merged 9 commits intoPowerShell:mainfrom Sep 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the add_metadata() function to pass input metadata from configuration resources to the actual resource invocations, enabling resources to access metadata during operations.
- Modified
add_metadata()function to accept an optionalresource_metadataparameter - For adapters, extend existing metadata with input metadata
- For resources, insert metadata as
_metadatakey in properties
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dsc_lib/src/configure/mod.rs | Modified add_metadata() function signature and logic to handle resource metadata, updated all call sites to pass resource metadata |
| dsc/tests/dsc_metadata.tests.ps1 | Added comprehensive tests for metadata passing across different operations (get, set, test, export) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
@SteveL-MSFT - looks like the key name is |
SteveL-MSFT
requested changes
Aug 21, 2025
SteveL-MSFT
approved these changes
Sep 4, 2025
Collaborator
|
@michaeltlombardi should this have a doc-impact label and requires to be documented for resource authors? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
subcommand.rsinto helper function to call from there andadd_metadata()add_metadata()to:_metadatakey intopropertiesfor resources that permit it in their schemametadatakey for adaptersPR Context